feat: support (at least) dual themes #26
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello 👋
This PR adds the support for dual themes in Shiki. This is very useful when a website have both a light and a dark theme.
With this feature, developers can still specifies a single theme but also two themes using an associative array.
In
shiki.js
, I use both variablestheme
andthemes
to align with the original Shiki API.related to https://shiki.style/guide/dual-themes
fix #22
I'm sorry for the formatting stuff in the JS files but I could open another PR to add a JS formatter.
I'm not a PHP expert and I'm not sure how to solve this type issue.