Times starting at 00:00 caused infinite loop (#45)

* Added a test to check if times set to 0:00 indeed lead to an infinite loop

* Fixed bug where 00:00 times caused an infinite loop

* Removed an opening hours to make sure the test runs with a 00:00 opening time

* File permissions for changelog & contributing as mentioned by SensioLabs Insight

* Added strict comparisation for start time

* Imported DateTime for OpeningHoursTest

* Used ->start()->same() method to compare times in OpeningHoursForDay

src/OpeningHoursForDay.php

@@ -68,7 +68,7 @@ protected function findNextOpenInFreeTime(Time $time, TimeRange $timeRange, Time
             TimeRange::fromString($prevTimeRange->end().'-'.$timeRange->start()) :
             TimeRange::fromString('00:00-'.$timeRange->start());
 
-        if ($timeOffRange->containsTime($time)) {
+        if ($timeOffRange->containsTime($time) || $timeOffRange->start()->isSame($time)) {
             return $timeRange->start();
         }
 

tests/OpeningHoursTest.php

@@ -162,7 +162,7 @@ public function it_can_determine_next_open_hours_from_non_working_date_time()
 
         $nextTimeOpen = $openingHours->nextOpen(new DateTime('2016-09-26 12:00:00'));
 
-        $this->assertInstanceOf('\DateTime', $nextTimeOpen);
+        $this->assertInstanceOf('DateTime', $nextTimeOpen);
         $this->assertEquals('2016-09-26 13:00:00', $nextTimeOpen->format('Y-m-d H:i:s'));
     }
 
@@ -176,7 +176,7 @@ public function it_can_determine_next_open_hours_from_working_date_time()
 
         $nextTimeOpen = $openingHours->nextOpen(new DateTime('2016-09-26 16:00:00'));
 
-        $this->assertInstanceOf('\DateTime', $nextTimeOpen);
+        $this->assertInstanceOf('DateTime', $nextTimeOpen);
         $this->assertEquals('2016-09-27 10:00:00', $nextTimeOpen->format('Y-m-d H:i:s'));
     }
 
@@ -193,7 +193,7 @@ public function it_can_determine_next_open_hours_from_early_morning()
 
         $nextTimeOpen = $openingHours->nextOpen(new DateTime('2016-09-26 04:00:00'));
 
-        $this->assertInstanceOf('\DateTime', $nextTimeOpen);
+        $this->assertInstanceOf('DateTime', $nextTimeOpen);
         $this->assertEquals('2016-09-27 10:00:00', $nextTimeOpen->format('Y-m-d H:i:s'));
     }
 
@@ -298,4 +298,15 @@ public function it_can_retrieve_a_list_of_exceptional_closing_dates()
         $this->assertEquals('2017-06-01', $exceptionalClosingDates[0]->format('Y-m-d'));
         $this->assertEquals('2017-06-02', $exceptionalClosingDates[1]->format('Y-m-d'));
     }
+
+    /** @test */
+    public function it_works_when_starting_at_midnight()
+    {
+        $openingHours = OpeningHours::create([
+            'monday' => ['00:00-16:00'],
+        ]);
+
+        $nextTimeOpen = $openingHours->nextOpen(new DateTime());
+        $this->assertInstanceOf('DateTime', $nextTimeOpen);
+    }
 }