Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve redis memory usage check #239

Merged

Conversation

pelmered
Copy link
Contributor

Improvements:

  • Added ->warnWhenAboveMb() to set a warning threshold
  • Sets memory usage in summary and meta data

@freekmurze freekmurze merged commit eeadb69 into spatie:main Jul 26, 2024
11 checks passed
@freekmurze
Copy link
Member

Thanks!

@pelmered
Copy link
Contributor Author

pelmered commented Jul 26, 2024

@freekmurze I'll probably add similar improvements to some other of the checks. For example DatabaseSizeCheck. Should I make one PR per check or just one big PR?

I'm also thinking about making checks for the following:

  • Elasticsearch
  • DB Snapshots (for your DB snapshot package)
  • Sentry errors

Should I add them here or make my own third part packages?

@freekmurze
Copy link
Member

I'd prefer separate PRs.

The new checks can go in packages of your own. Feel free to send a PR to our docs to add a link to them 👍

@pelmered
Copy link
Contributor Author

Ok, great. I will do that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants