Merge pull request #205 from jonnyka/cachecheck-racecondition-fix

Fixed the CacheCheck causing race conditions in some cases
spatie · Dec 5, 2023 · 4e4ab00 · 4e4ab00
2 parents f7fc30c + 48ffec9
commit 4e4ab00
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/src/Checks/Checks/CacheCheck.php b/src/Checks/Checks/CacheCheck.php
@@ -45,9 +45,13 @@ protected function canWriteValuesToCache(?string $driver): bool
     {
         $expectedValue = Str::random(5);
 
-        Cache::driver($driver)->put('laravel-health:check', $expectedValue, 10);
+        $cacheName = "laravel-health:check-{$expectedValue}";
 
-        $actualValue = Cache::driver($driver)->get('laravel-health:check');
+        Cache::driver($driver)->put($cacheName, $expectedValue, 10);
+
+        $actualValue = Cache::driver($driver)->get($cacheName);
+
+        Cache::driver($driver)->forget($cacheName);
 
         return $actualValue === $expectedValue;
     }