Merge pull request #1351 from ashleyshenton/php-8.4

fix: php 8.4 deprecation warnings
spatie · Nov 18, 2024 · 9abddaa · 9abddaa
2 parents 779b0a1 + b774849
commit 9abddaa
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/docs/advanced-usage/batch-logs.md b/docs/advanced-usage/batch-logs.md
@@ -127,7 +127,7 @@ Activity::forBatch($uuid)->get(); // all the activity that happend in the batch
 ```php
 class SomeJob
 {
-    public function handle(string $value, string $batchUuid = null)
+    public function handle(string $value, ?string $batchUuid = null)
     {
         LogBatch::startBatch();
         if($batchUuid) LogBatch::setBatch($batchUuid);

diff --git a/src/ActivityLogger.php b/src/ActivityLogger.php
@@ -133,7 +133,7 @@ public function inLog(?string $logName): static
         return $this->useLog($logName);
     }
 
-    public function tap(callable $callback, string $eventName = null): static
+    public function tap(callable $callback, ?string $eventName = null): static
     {
         call_user_func($callback, $this->getActivity(), $eventName);
 

diff --git a/src/helpers.php b/src/helpers.php
@@ -4,7 +4,7 @@
 use Spatie\Activitylog\ActivityLogStatus;
 
 if (! function_exists('activity')) {
-    function activity(string $logName = null): ActivityLogger
+    function activity(?string $logName = null): ActivityLogger
     {
         $defaultLogName = config('activitylog.default_log_name');