Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Laravel/Illuminate 11 Support #461

Merged
merged 5 commits into from
Feb 15, 2024
Merged

Add Laravel/Illuminate 11 Support #461

merged 5 commits into from
Feb 15, 2024

Conversation

Jubeki
Copy link
Contributor

@Jubeki Jubeki commented Feb 14, 2024

This forces to install Illuminate 10 or 11 depending on the selected Laravel version.

@Jubeki Jubeki changed the title Add Laravel 11 Support Add Laravel/Illuminate 11 Support Feb 14, 2024
@Jubeki Jubeki marked this pull request as ready for review February 14, 2024 15:52
@Jubeki Jubeki mentioned this pull request Feb 14, 2024
Merged
@Jubeki
Copy link
Contributor Author

Jubeki commented Feb 14, 2024

Also, it seems like you are still using nicmart/[email protected] but there is already nicmart/[email protected] installed. Maybe this is something to consider to update. (see https://github.com/nicmart/Tree/releases/tag/0.8.0)

@freekmurze
Copy link
Member

Feel free to update the tree package to 0.8. If the tests pass I'll merge it in!

@Jubeki
Copy link
Contributor Author

Jubeki commented Feb 14, 2024

@freekmurze Tests pass on my fork: https://github.com/Jubeki/spatie-crawler/actions/runs/7903886717

@freekmurze freekmurze merged commit 807d145 into spatie:main Feb 15, 2024
10 checks passed
@freekmurze
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jubeki @freekmurze