Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed ignoreHttpsErrors() method #899

Merged
merged 1 commit into from
Nov 25, 2024
Merged

Fixed ignoreHttpsErrors() method #899

merged 1 commit into from
Nov 25, 2024

Conversation

PHLAK
Copy link
Contributor

@PHLAK PHLAK commented Nov 5, 2024 •
edited
Loading

With the release of Puppeteer v23 the ignoreHttpsErrors was renamed to acceptInsecureCerts.

Updated the ignoreHttpsErrors() method to use the new acceptInsecureCerts option.

@PHLAK
Copy link
Contributor Author

PHLAK commented Nov 5, 2024

I see a test failed (i.e. it will connect to a custom ws endpoint and take screenshot) however I'm not sure it has anything to do with the change in this PR but please let me know if there's something I can do to fix it.

@AlexVanderbist AlexVanderbist added the next major Features for the next major version. label Nov 25, 2024
@AlexVanderbist AlexVanderbist self-assigned this Nov 25, 2024
@AlexVanderbist
Copy link
Member

AlexVanderbist commented Nov 25, 2024 •
edited
Loading

Hey @PHLAK, thanks for the PR. The failing test has already been fixed on main. I'll merge and tag this as v5.0.0 which will also be the first version of Browsershot with a minimum Puppeteer version requirement :)

@AlexVanderbist AlexVanderbist merged commit 3ff350c into spatie:main Nov 25, 2024
1 of 5 checks passed
@PHLAK
Copy link
Contributor Author

PHLAK commented Nov 25, 2024

Thanks @AlexVanderbist!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@AlexVanderbist AlexVanderbist

Labels
next major Features for the next major version.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PHLAK @AlexVanderbist