Added file:/ to the list of excluded paths and string contains & added option to disable redirects #881
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
src/Browsershot.php
to ensure that external linking to a file does not work, as this very easily introduces a security vulnerability.In this PR - I simply introduce a further check to not only check for
file://
but also forfile:/
- which also works for linking to local files alongside some tests to check this.A straightforward POC to demonstrate this being used is:
Browsershot::url('file:/etc/password')->save("vuln.pdf");
Which allows the password file to be generated out as a PDF. This flaw can be further exploited to bypass the security filters and read local files from the applicationserver through the use of iFrames, leading to unauthorised access and potential data compromise.
In this PR - the option to disable redirects is added alongside some tests to ensure this still works when a redirect isn't returned.
https://cwe.mitre.org/data/definitions/425.html
You would have received an email from Tanto Security regarding this - who should be credited with finding these issues.