Update handling of browser output for Puppeteer ^23.0.0 #870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Puppeteer modified how they return stream data, for browser compatibility reasons (#12823)
After this update, a UInt8Array byte stream is returned, instead of a Buffer.
This PR adjusts the handling of this output to be compatible with v23's output. All tests appear green, save for three which fail due to the requests list not being populated. I believe I know the cause, and will submit a PR to fix it.
Tests remain green when running Puppeteer 22.15.0 as well, so this fix should be backwards compatible with older versions that returned a Buffer rather than UInt8Array.