Fixed the path for PID_DIR, when the WORKDIR is home #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josiahsams
reviewed
Jan 25, 2017
| @@ -21,7 +21,7 @@ while [ "$1" != "" ]; do | |||
| shift; | |||
| done; | |||
|
|
|||
| export PID_DIR=${WORKDIR}/pid_monitor | |||
| export PID_DIR=${WORKDIR}/perftools-setup/pid_monitor | |||
There was a problem hiding this comment.
Can you please check the path where we extract the pid_monitor in our setup scripts: https://github.com/josiahsams/perftools-setup/blob/master/install.sh#L80
There was a problem hiding this comment.
This is the place below, so seems there should not be a need to modify the code, I have destroyed my cluster, will revisit this when we plan to re run the code.
Steps to install pid_monitor.
if [ ! -d ${WORKDIR}/pid_monitor ]; then
git clone https://github.com/jschaub30/pid_monitor
mkdir -p ${WORKDIR}/pid_monitor/rundir
#Set execute permission for others so that apache can read files from this directory.
sudo chmod o+x ${WORKDIR} ${WORKDIR}/pid_monitor ${WORKDIR}/pid_monitor/rundir
fi
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was getting errors that setup-run.sh was not found
/home/hdp_test//perftools-setup/pmonitor/pmon: line 34: /home/hdp_test/pid_monitor/setup-run.sh: No such file or directory
SLAVES : localhost localhost
/home/hdp_test//perftools-setup/pmonitor/pmon: line 64: ./run-workload.sh: No such file or directory