Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refs platform/3099: update ingress-nginx to 1.11.2 #16

Merged
merged 3 commits into from
Sep 9, 2024

Conversation

Stevesibilia
Copy link
Contributor

@Stevesibilia Stevesibilia commented Sep 9, 2024

PR Type

Enhancement


Description

  • Updated Ingress-Nginx chart version from 4.10.1 to 4.11.2 to address CVE-2024-7646 (kubernetes issue #126744)
  • Modified variables.tf to reflect the new default chart version
  • Updated CHANGELOG.md with new version 0.7.0 and details about the security fix
  • Updated README.md to show the new default chart version in the inputs table
  • Updated reference URL in files/values.yaml.tftpl to point to the new chart version

Changes walkthrough 📝

Relevant files
Enhancement
variables.tf
Update Ingress-Nginx chart version                                             

variables.tf

  • Updated default chart_version from "4.10.1" to "4.11.2"
+1/-1     
Documentation
CHANGELOG.md
Update CHANGELOG with new version and security fix             

CHANGELOG.md

  • Added new entry for version 0.7.0
  • Documented update to Ingress-nginx 1.11.2
  • Mentioned fix for CVE-2024-7646
  • +8/-0     
    README.md
    Update README with new chart version                                         

    README.md

  • Updated default value for chart_version input variable from "4.10.1"
    to "4.11.2"
  • +1/-1     
    values.yaml.tftpl
    Update reference URL for values.yaml                                         

    files/values.yaml.tftpl

  • Updated reference URL for values.yaml from helm-chart-4.10.1 to
    helm-chart-4.11.2
  • +1/-1     

    💡 PR-Agent usage:
    Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

    @sparkfabrik-ai-bot
    Copy link

    PR Reviewer Guide 🔍

    ⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ No key issues to review

    @sparkfabrik-ai-bot
    Copy link

    PR Code Suggestions ✨

    CategorySuggestion                                                                                                                                    Score
    Enhancement
    Expand the changelog entry with more details about the changes in the new version

    Consider adding more details about the changes introduced in version 0.7.0. For
    example, you could mention any specific improvements or new features that come with
    the updated Ingress-nginx version, beyond just addressing the CVE.

    CHANGELOG.md [15-17]

     ### Changed
     
    -- Update to use Ingress-nginx 1.11.2 to solve CVE-2024-7646 (https://github.com/kubernetes/kubernetes/issues/126744)
    +- Update to Ingress-nginx 1.11.2:
    +  - Addresses CVE-2024-7646 (https://github.com/kubernetes/kubernetes/issues/126744)
    +  - Improves [specific feature or performance aspect]
    +  - Adds support for [new capability, if applicable]
     
    Suggestion importance[1-10]: 7

    Why: The suggestion provides valuable additional context about the update, which can be helpful for users. However, it's not crucial for the functionality of the code.

    7
    Maintainability
    Add a descriptive comment to explain the purpose and usage of the file

    Consider adding a brief comment explaining the purpose of this file and how it's
    used in the context of the module. This can help other developers understand its
    role more quickly.

    files/values.yaml.tftpl [1]

    -# https://github.com/kubernetes/ingress-nginx/blob/helm-chart-4.11.2/charts/ingress-nginx/values.yaml
    +# This file contains the default values for the Ingress-nginx Helm chart.
    +# It's used as a template for customizing the chart installation.
    +# Reference: https://github.com/kubernetes/ingress-nginx/blob/helm-chart-4.11.2/charts/ingress-nginx/values.yaml
     
    Suggestion importance[1-10]: 6

    Why: The suggestion improves code documentation and maintainability, which is beneficial but not critical for the code's functionality.

    6

    CHANGELOG.md Outdated Show resolved Hide resolved
    CHANGELOG.md Outdated Show resolved Hide resolved
    Stevesibilia and others added 2 commits September 9, 2024 14:59
    Co-authored-by: Daniele Monti <[email protected]>
    Co-authored-by: Daniele Monti <[email protected]>
    Copy link
    Contributor

    @Monska85 Monska85 left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    LGTM 👍

    @Stevesibilia Stevesibilia merged commit dce79d3 into main Sep 9, 2024
    1 check passed
    @Stevesibilia Stevesibilia deleted the feat/3099_update_ingress_controller branch September 9, 2024 13:01
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants