Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: install plugin dependencies in deployment workflow #62

Merged
merged 1 commit into from
Sep 28, 2023
Merged

fix: install plugin dependencies in deployment workflow #62

merged 1 commit into from
Sep 28, 2023

Conversation

dustin-jw
Copy link
Contributor

Description

This fixes our deployment workflow, which is missing the step to install plugin dependencies, causing the build to fail.

To Validate

  1. Make sure all PR Checks have passed
  2. Pull down this branch
  3. Run npm ci
  4. Run npm run plugins:install
  5. Run npm run build:prod
  6. Confirm that each of these steps ran successfully and compare them to the deployment workflow, which should effectively do the same thing

rise-erpelding
rise-erpelding approved these changes Sep 28, 2023
View reviewed changes
Copy link
Contributor

@rise-erpelding rise-erpelding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this should work!

jonoliver
jonoliver approved these changes Sep 28, 2023
View reviewed changes
Copy link
Member

@jonoliver jonoliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Successful deployment dispatched from this branch: https://github.com/sparkbox/sparkpress-wordpress-starter/actions/runs/6343364748

@dustin-jw dustin-jw merged commit 7be22cb into main Sep 28, 2023
2 checks passed
@dustin-jw dustin-jw deleted the fix--deploy-workflow branch September 28, 2023 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rise-erpelding rise-erpelding rise-erpelding approved these changes

@jonoliver jonoliver jonoliver approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dustin-jw @jonoliver @rise-erpelding