refactor: use generic environment variable example to avoid confusion #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rise-erpelding
approved these changes
Sep 26, 2023
dustin-jw
force-pushed
the
refactor--env-var-example
branch
from
4ee3bc6 to
18e25fb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
GOOGLE_API_KEYexample for loading an environment variable could lead to confusion, since a developer could reasonably expect that it was wired up to a tag manager/analytics script, then be surprised that it didn't do anything. This replaces that key with something that's more clearly an example and includes a comment to reinforce that it's an example.Closes #54
To Validate
npm start