Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: create custom blocks #53

Merged
merged 12 commits into from
Sep 28, 2023
Merged

Feat: create custom blocks #53

merged 12 commits into from
Sep 28, 2023

Conversation

rise-erpelding
Copy link
Contributor

@rise-erpelding rise-erpelding commented Sep 26, 2023

Description

  • Adds example plugins
  • Allows for multiple blocks to be added without additional configuration in example-blocks/package.json or example-blocks/example-blocks.php

Closes #22

To Validate

  1. Make sure all PR Checks have passed
  2. Pull down this branch
  3. Run npm run plugins:install
  4. Run npm start
  5. Go to http://localhost:8000/wp-admin/plugins.php and activate the "Example Blocks" plugin.
  6. Go to posts, create a new post or edit an existing post, and confirm that the "Reverse String" and "Hello World" blocks are available blocks (under its own section, "Example Custom Blocks").
  7. Preview the post and confirm that blocks are displayed as expected.
  8. Run added lint scripts (npm run lint:plugins:js, npm run lint:plugins:css, npm run plugins:format) and confirm that they appear to be working.

@rise-erpelding rise-erpelding force-pushed the feat--create-custom-blocks branch 4 times, most recently from 79025d9 to 4242778 Compare September 26, 2023 21:37
@rise-erpelding rise-erpelding marked this pull request as ready for review September 26, 2023 21:38
Copy link
Contributor

@dustin-jw dustin-jw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this works great! I just had a few nitpicks and npm script things that could be adjusted a bit.

package.json Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
src/plugins/example-blocks/readme.txt Outdated Show resolved Hide resolved
src/plugins/example-blocks/scripts/build-blocks.sh Outdated Show resolved Hide resolved
src/plugins/example-blocks/scripts/start-blocks.sh Outdated Show resolved Hide resolved
src/plugins/example-blocks/example-blocks.php Outdated Show resolved Hide resolved
src/plugins/example-blocks/example-blocks.php Show resolved Hide resolved
@rise-erpelding rise-erpelding merged commit 05116f0 into main Sep 28, 2023
1 check passed
@rise-erpelding rise-erpelding deleted the feat--create-custom-blocks branch September 28, 2023 15:15
@rise-erpelding rise-erpelding restored the feat--create-custom-blocks branch September 28, 2023 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add custom plugin example
2 participants