-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: create custom blocks #53
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rise-erpelding
force-pushed
the
feat--create-custom-blocks
branch
4 times, most recently
from
September 26, 2023 21:37
79025d9
to
4242778
Compare
rise-erpelding
commented
Sep 26, 2023
dustin-jw
requested changes
Sep 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this works great! I just had a few nitpicks and npm script things that could be adjusted a bit.
rise-erpelding
force-pushed
the
feat--create-custom-blocks
branch
from
September 27, 2023 21:11
d3bbd1b
to
05116f0
Compare
dustin-jw
approved these changes
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
example-blocks/package.json
orexample-blocks/example-blocks.php
Closes #22
To Validate
npm run plugins:install
npm start
npm run lint:plugins:js
,npm run lint:plugins:css
,npm run plugins:format
) and confirm that they appear to be working.