chore: update php + wordpress versions #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theogainey
force-pushed
the
chore--upgrade-php-wordpress
branch
4 times, most recently
from
b4e1b58 to
c73c55c
Compare
jonoliver
force-pushed
the
chore--upgrade-php-wordpress
branch
from
c73c55c to
285c4e7
Compare
.circleci/config.yml
Outdated
| @@ -6,7 +6,7 @@ jobs: | |||
| - image: circleci/php:7.1-node-browsers | |||
There was a problem hiding this comment.
I noticed this and wondered if the php version needs to be updated here too?
There was a problem hiding this comment.
Good catch, we should update it here, although we don't have a way to validate it since we don't have circle CI set up for the project. This configuration will likely go away when we address #21 in favor of a Github action, but we can updated it now to keep it in sync.
jonoliver
reviewed
Sep 18, 2023
Dockerfile
Outdated
|
|
||
| # When changings, also change in .circleci/config.yml | ||
| ENV WP_VERSION=5.5 | ||
| ENV WP_VERSION=6.3 |
There was a problem hiding this comment.
We can go ahead and update this to 6.3.1, the latest current version
jonoliver
requested changes
Sep 18, 2023
theogainey
force-pushed
the
chore--upgrade-php-wordpress
branch
from
285c4e7 to
6ad0baf
Compare
rise-erpelding
approved these changes
Sep 19, 2023
theogainey
force-pushed
the
chore--upgrade-php-wordpress
branch
from
6ad0baf to
1a4e078
Compare
jonoliver
approved these changes
Sep 19, 2023
- modified Dockerfile to support updated php & wordpress versions - modified composer.json to support updated php version
theogainey
force-pushed
the
chore--upgrade-php-wordpress
branch
from
1a4e078 to
b4c169d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the Dockerfile to use php version 8.1 and Wordpress version 6.3. Additionally this PR updates composer.json to use php version 8.1
Closes #16
To Validate
docker compose buildnpm run startdocker exec sparkpress php -v