fix: custom post type tags excluded from archive pages #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dustin-jw
force-pushed
the
fix--custom-post-type-tags
branch
3 times, most recently
from
c6f9061 to
44ede79
Compare
robtarr
reviewed
Nov 7, 2023
| // Defines an `example` JavaScript variable, within the sparkpress-theme-script, equal to $example_data. | ||
| wp_localize_script( 'sparkpress-theme-script', 'example', $example_data ); | ||
|
|
||
| // You can also define global variables that get appended to an enqueued script. |
- turn example code into a comment - remove redundant class in generated page templates - update instructions for creating post types - comment out unnecessary add_filter call
dustin-jw
force-pushed
the
fix--custom-post-type-tags
branch
from
c5077f2 to
481c68a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes an issue where posts from custom post types were excluded from archive pages, such as by date, category, or tag, as well as the home page which lists recent posts. It requires a little bit of manual intervention from developers when they generate post types, but it's a one-liner, and instructions were updated to make it clear what to do on post type creation.
Closes #115
To Validate
npm startnpm run generate:post-typeand answer the prompts to create a new custom post type, like "Recipes"enable_custom_posts_in_archivesfunction?tag=<tag-slug>) to confirm all posts with that tag are rendered?cat=<category-id>) to confirm all posts with that category are rendered?m=2023) to confirm all posts authored in the given year are rendered?post_type=<post-slug>) and confirm that only posts from the custom post type are rendered