-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support featured image #110
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rise-erpelding
force-pushed
the
support-featured-image
branch
2 times, most recently
from
October 24, 2023 00:55
bf3553d
to
a2ced97
Compare
rise-erpelding
commented
Oct 24, 2023
rise-erpelding
commented
Oct 24, 2023
rise-erpelding
force-pushed
the
support-featured-image
branch
from
October 24, 2023 01:02
a2ced97
to
25daafa
Compare
jonoliver
reviewed
Oct 24, 2023
jonoliver
requested changes
Oct 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work Rise! To capture the requested changes:
- Update
resize
value to960
- Remove character truncation from
post.preview
I added #111 to capture making the images responsive at different viewport widths.
rise-erpelding
force-pushed
the
support-featured-image
branch
from
October 24, 2023 18:41
4751641
to
2f03d9f
Compare
jonoliver
approved these changes
Oct 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you Rise!
rise-erpelding
force-pushed
the
support-featured-image
branch
from
October 24, 2023 20:04
2f03d9f
to
08c7bb1
Compare
- adds featured image to archive page - adds featured image to top of post
rise-erpelding
force-pushed
the
support-featured-image
branch
from
October 24, 2023 20:10
08c7bb1
to
caeb1b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Utilizes the featured image on a WordPress post in the post list (archive page) as a thumbnail and in the post.
Addresses #75
To Validate
npm start
lorem-ipsum-with-img-2023-10-23T23-16-57_UTC.sql.gz