Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support featured image #110

Merged
merged 1 commit into from
Oct 24, 2023
Merged

Support featured image #110

merged 1 commit into from
Oct 24, 2023

Conversation

rise-erpelding
Copy link
Contributor

@rise-erpelding rise-erpelding commented Oct 24, 2023

Description

Utilizes the featured image on a WordPress post in the post list (archive page) as a thumbnail and in the post.

Addresses #75

To Validate

  1. Make sure all PR Checks have passed
  2. Pull down this branch
  3. Run npm start
  4. If you have posts with images, keep the database you already have, or add your own, or use the db backup attached below.
  5. Navigate to localhost:8000 to check the archive page, check that thumbnails render and that styling seems appropriate.
  6. Navigate to a post page that has a thumbnail image and check that image renders there and that styling seems appropriate.
  7. Add a post with a featured image and confirm that image appears on archive page and on post page as expected.
  8. Add alt text to a featured image if it does not have one already (you can do this in the Post by clicking on "Replace" to replace the image, then update the details and save). Confirm that the alt text is visible on the image for the archive page and for the post page.

lorem-ipsum-with-img-2023-10-23T23-16-57_UTC.sql.gz

@rise-erpelding rise-erpelding force-pushed the support-featured-image branch 2 times, most recently from bf3553d to a2ced97 Compare October 24, 2023 00:55
@rise-erpelding rise-erpelding marked this pull request as ready for review October 24, 2023 01:03
src/php/views/page.twig Outdated Show resolved Hide resolved
Copy link
Member

@jonoliver jonoliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work Rise! To capture the requested changes:

  • Update resize value to 960
  • Remove character truncation from post.preview

I added #111 to capture making the images responsive at different viewport widths.

Copy link
Member

@jonoliver jonoliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Rise!

- adds featured image to archive page
- adds featured image to top of post
@rise-erpelding rise-erpelding merged commit caeb1b7 into main Oct 24, 2023
2 checks passed
@rise-erpelding rise-erpelding deleted the support-featured-image branch October 24, 2023 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants