Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: check commit messages and run tests in CI #107

Merged
merged 1 commit into from
Oct 24, 2023
Merged

Conversation

dustin-jw
Copy link
Contributor

@dustin-jw dustin-jw commented Oct 23, 2023

Description

This updates our PR workflow to check that commits follow conventional commits patterns, and it runs tests. The file/job names were updated for accuracy.

Closes #99

To Validate

Make sure all PR Checks have passed, including "Check Commit Message" and "Lint & Test"

Copy link
Member

@jonoliver jonoliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The passing workflow looks good 👍. Can we force a failure to ensure that the workflow fails properly?

@dustin-jw
Copy link
Contributor Author

dustin-jw commented Oct 24, 2023

The passing workflow looks good 👍. Can we force a failure to ensure that the workflow fails properly?

Sure thing! Pushed a drop: * commit.

Copy link
Member

@jonoliver jonoliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Dustin!

@dustin-jw dustin-jw merged commit 0f04f40 into main Oct 24, 2023
2 checks passed
@dustin-jw dustin-jw deleted the chore--pr-workflow branch October 24, 2023 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update CI workflow to run tests and enforce conventional commits
2 participants