improvement: set more logger metadata, and reset it after span closes #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zachdaniel
force-pushed
the
more-and-better-logger-metadata
branch
from
ec9e91b to
81b80ea
Compare
Adds support for configuring a service version in tracer options, which can be used for tracking service deployments and their performance regressions.
* Prepare for 3.2.0 release
zachdaniel
force-pushed
the
more-and-better-logger-metadata
branch
from
7163b2a to
8fbd0ec
Compare
|
I've merged the changes from #142 in this branch because I needed them in addition to my changes. We should merge that one first. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tracks things like service_version and service in the logger metadata, and also fixes an issue where logger metadata would persist even after a span for a given service has closed. Now we set it to the logger metadata of the current span after closing a span.