Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v0.2.2 #11

Merged
merged 4 commits into from
Dec 19, 2023
Merged

v0.2.2 #11

merged 4 commits into from
Dec 19, 2023

Conversation

jwfraustro
Copy link
Collaborator

  • moves Parameters documentation to the correct class
  • updates the Parameter class's value type hint to be any primitive - iterables, others, wouldn't be valid anyway.
  • bug fix for VOSIAvailability to set its Optional values to None correctly - a requirement for Pydantic v2

@jwfraustro jwfraustro self-assigned this Dec 18, 2023
@jwfraustro jwfraustro changed the title V0.2.2 v0.2.2 Dec 18, 2023
tomdonaldson
tomdonaldson approved these changes Dec 19, 2023
View reviewed changes
Copy link
Collaborator

@tomdonaldson tomdonaldson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@jwfraustro jwfraustro merged commit 2753176 into main Dec 19, 2023
2 checks passed
@jwfraustro jwfraustro deleted the v0.2.2 branch December 19, 2023 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomdonaldson tomdonaldson tomdonaldson approved these changes

@falkben falkben Awaiting requested review from falkben

@seweissman seweissman Awaiting requested review from seweissman

@theresadower theresadower Awaiting requested review from theresadower

Assignees

@jwfraustro jwfraustro

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jwfraustro @tomdonaldson