Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HLA-1312: Numpy 2.0 scalar promotion issues in STWCS #206

Merged
merged 11 commits into from
Sep 18, 2024
Merged

HLA-1312: Numpy 2.0 scalar promotion issues in STWCS #206

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
0ce3497
initial commit
s-goldman Aug 29, 2024
57652ea
added changelog
s-goldman Aug 29, 2024
a414a05
removed trailing whitespace.
s-goldman Aug 29, 2024
59fa5e2
only necessary changes.
s-goldman Sep 3, 2024
7c0d7da
Update CHANGES.rst
s-goldman Sep 4, 2024
dabf9ff
Merge branch 'spacetelescope:master' into hla-1312_numpy2_scalar_prom…
s-goldman Sep 17, 2024
5de1286
promotion of float on instantiation.
s-goldman Sep 17, 2024
6d3ab1b
remove lines from alternative method.
s-goldman Sep 17, 2024
ea824e4
removed added space.
s-goldman Sep 17, 2024
baa9b41
updated changelog entry with more accurate description.
s-goldman Sep 17, 2024
6f4561e
Update stwcs/distortion/mutil.py
s-goldman Sep 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGES.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
1.7.3 (Unreleased)
------------------

- Manual scalar promotion of refpix['PSCALE'] from float32
to float64 to avoid future Numpy 2.0 issues [#206].

- Pin astropy min version to 5.0.4. [#191]

1.7.2 (2021-11-29)
Expand Down
2 changes: 1 addition & 1 deletion stwcs/distortion/mutil.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,7 +202,7 @@ def readIDCtab(tabname, chip=1, date=None, direction='forward',
refpix['YREF'] = ftab[1].data.field('YREF')[row]
refpix['XSIZE'] = ftab[1].data.field('XSIZE')[row]
refpix['YSIZE'] = ftab[1].data.field('YSIZE')[row]
refpix['PSCALE'] = round(ftab[1].data.field('SCALE')[row], 8)
refpix['PSCALE'] = round(float(ftab[1].data.field('SCALE')[row]), 8)
refpix['V2REF'] = v2ref
refpix['V3REF'] = v3ref
refpix['THETA'] = theta
Expand Down
Loading