Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix downstream ci #191

Merged
merged 1 commit into from
Oct 14, 2024
Merged

Conversation

braingram
Copy link
Collaborator

@braingram braingram commented Oct 3, 2024

See spacetelescope/stcal#297
These are the same changes adapted to this package.

Currently downstream testing of jwst and romancal end up using the pyproject.toml in this repository for determining pytest configuration.
This ends up with pytest using options in these downstream tests that differ from the options used by the downstream packages in their tests (when run in their own CI). This in turn results in lots of false failures in our downstream testing.

This PR changes how the jwst and romancal downstream tests to use the pytest options defined in the respective repositories.

Tasks

  • update or add relevant tests
  • update relevant docstrings and / or docs/ page
  • Does this PR change any API used downstream? (if not, label with no-changelog-entry-needed)
    • write news fragment(s) in changes/: echo "changed something" > changes/<PR#>.<changetype>.rst (see below for change types)
    • run regression tests with this branch installed ("git+https://github.com/<fork>/stpipe@<branch>")
news fragment change types...
  • changes/<PR#>.feature.rst: new feature
  • changes/<PR#>.bugfix.rst: fixes an issue
  • changes/<PR#>.doc.rst: documentation change
  • changes/<PR#>.removal.rst: deprecation or removal of public API
  • changes/<PR#>.misc.rst: infrastructure or miscellaneous change

Copy link

codecov bot commented Oct 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.66%. Comparing base (5efae61) to head (3a03c8c).
Report is 6 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #191       +/-   ##
===========================================
+ Coverage   73.29%   94.66%   +21.36%     
===========================================
  Files          25       37       +12     
  Lines        1917     3109     +1192     
===========================================
+ Hits         1405     2943     +1538     
+ Misses        512      166      -346     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@braingram braingram added the no-changelog-entry-needed does not require an entry in `CHANGES.rst` label Oct 3, 2024
@braingram braingram marked this pull request as ready for review October 3, 2024 19:18
@braingram braingram requested a review from a team as a code owner October 3, 2024 19:18
@braingram braingram requested a review from nden October 3, 2024 19:18
@braingram braingram mentioned this pull request Oct 8, 2024
7 tasks
@braingram braingram enabled auto-merge October 11, 2024 12:43
@braingram braingram requested a review from emolter October 11, 2024 12:43
Copy link
Collaborator

@emolter emolter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not confident enough in my understanding to approve this or find problems, but thanks for requesting my review anyway, it's fun to learn how to write CI workflows.

@braingram
Copy link
Collaborator Author

I'm not confident enough in my understanding to approve this or find problems, but thanks for requesting my review anyway, it's fun to learn how to write CI workflows.

Thanks! I was hoping your approval would be enough to get this in but it doesn't look like you're an "approved approver".

@braingram braingram merged commit 0c3d37e into spacetelescope:main Oct 14, 2024
18 of 19 checks passed
@braingram braingram deleted the fix_downstream branch October 14, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog-entry-needed does not require an entry in `CHANGES.rst`
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants