-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix downstream ci #191
fix downstream ci #191
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #191 +/- ##
===========================================
+ Coverage 73.29% 94.66% +21.36%
===========================================
Files 25 37 +12
Lines 1917 3109 +1192
===========================================
+ Hits 1405 2943 +1538
+ Misses 512 166 -346 ☔ View full report in Codecov by Sentry. |
e5b38c9
to
3f98aa9
Compare
3f98aa9
to
3a03c8c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not confident enough in my understanding to approve this or find problems, but thanks for requesting my review anyway, it's fun to learn how to write CI workflows.
Thanks! I was hoping your approval would be enough to get this in but it doesn't look like you're an "approved approver". |
See spacetelescope/stcal#297
These are the same changes adapted to this package.
Currently downstream testing of jwst and romancal end up using the pyproject.toml in this repository for determining pytest configuration.
This ends up with pytest using options in these downstream tests that differ from the options used by the downstream packages in their tests (when run in their own CI). This in turn results in lots of false failures in our downstream testing.
This PR changes how the jwst and romancal downstream tests to use the pytest options defined in the respective repositories.
Tasks
docs/
pageno-changelog-entry-needed
)changes/
:echo "changed something" > changes/<PR#>.<changetype>.rst
(see below for change types)"git+https://github.com/<fork>/stpipe@<branch>"
)jwst
regression testromancal
regression testnews fragment change types...
changes/<PR#>.feature.rst
: new featurechanges/<PR#>.bugfix.rst
: fixes an issuechanges/<PR#>.doc.rst
: documentation changechanges/<PR#>.removal.rst
: deprecation or removal of public APIchanges/<PR#>.misc.rst
: infrastructure or miscellaneous change