use pytest.importorskip on test utils

[zacharyburnett]

closes #114

use pytest.importorskip to import util to make test image, to keep abstract model tests from failing if roman_datamodels is not installed

stpipe/src/stpipe/tests/test_abstract_datamodel.py

Lines 8 to 13 in 58def5a

	def test_roman_datamodel():
	roman_datamodels = pytest.importorskip("roman_datamodels.datamodels")
	import roman_datamodels.tests.util as rutil
	roman_image_tree = rutil.mk_level2_image()
	image_model = roman_datamodels.ImageModel(roman_image_tree)
	assert isinstance(image_model, AbstractDataModel)

[codecov]

Codecov Report

All modified lines are covered by tests ✅

📢 Thoughts on this report? Let us know!.

[braingram]

I no longer see the roman_datamodels.tests.util submodule in roman_datamodels. mk_level2_image is available from roman_datamodels.maker_utils.

Suggested change

	rutil = pytest.importorskip("roman_datamodels.tests.util")
	rutil = pytest.importorskip("roman_datamodels.maker_utils")

What options are there for updating the stpipe CI to run this test? At the moment I'm failing to find a run that installs roman_datamodels and runs the stpipe tests.

[WilliamJamieson]

There should be a datamodels install target which installs stdatamodels and roman_datamodels. One of the test cases can specify that additional target.

[Hellseher]

Why roman_datamodels is not mentioned in test dependencies:

stpipe/pyproject.toml

Lines 22 to 35 in 5369e85

	[project.optional-dependencies]
	docs = [
	'numpydoc',
	'sphinx',
	'sphinx-automodapi',
	'sphinx-rtd-theme',
	'stsci-rtd-theme',
	'tomli; python_version <"3.11"',
	]
	test = [
	'pytest >=7.0.0',
	'pytest-doctestplus >=0.10.0',
	]

And not in install dependencies:

stpipe/pyproject.toml

Lines 14 to 19 in 5369e85

	dependencies = [
	'asdf>=2.13',
	'crds>=7.4.1.3',
	'astropy>=5.0.4',
	'importlib_metadata>=4.11.4',
	]

[zacharyburnett]

superseded by #118