Update the style checks for stpipe #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #103 +/- ##
==========================================
+ Coverage 54.80% 54.99% +0.19%
==========================================
Files 25 25
Lines 3020 3002 -18
==========================================
- Hits 1655 1651 -4
+ Misses 1365 1351 -14 ☔ View full report in Codecov by Sentry. |
zacharyburnett
approved these changes
Aug 29, 2023
WilliamJamieson
force-pushed
the
update/style
branch
2 times, most recently
from
84c2b15 to
9d9e96e
Compare
This will make comprehensions marginally faster
Using fprint format and passing values in as extras to log is significantly faster and more secure than f strings
Prettier has the same idea as black, but for non python file types.
WilliamJamieson
force-pushed
the
update/style
branch
from
9d9e96e to
ba6ae32
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleanup and implement better style checks for stpipe