Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove deprecated schema_editor #373

Merged
merged 2 commits into from
Jan 3, 2025

Conversation

braingram
Copy link
Collaborator

@braingram braingram commented Jan 3, 2025

Now that 2.2.0 is out we can remove schema_editor.

This PR removes the deprecated and unused schema_editor. I don't think this warrants a major version bump (so with this PR the next release would be 2.3.0).

Closes #355

Tasks

  • update or add relevant tests
  • update relevant docstrings and / or docs/ page
  • Does this PR change any API used downstream? (if not, label with no-changelog-entry-needed)
    • write news fragment(s) in changes/: echo "changed something" > changes/<PR#>.<changetype>.rst (see below for change types)
    • run jwst regression tests with this branch installed ("git+https://github.com/<fork>/stdatamodels@<branch>")
news fragment change types...
  • changes/<PR#>.feature.rst: new feature
  • changes/<PR#>.bugfix.rst: fixes an issue
  • changes/<PR#>.doc.rst: documentation change
  • changes/<PR#>.removal.rst: deprecation or removal of public API
  • changes/<PR#>.misc.rst: infrastructure or miscellaneous change

@braingram braingram marked this pull request as ready for review January 3, 2025 15:35
@braingram braingram requested a review from a team as a code owner January 3, 2025 15:35
Copy link

codecov bot commented Jan 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.17%. Comparing base (788f7bd) to head (b803990).
Report is 5 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #373       +/-   ##
===========================================
+ Coverage   67.59%   78.17%   +10.57%     
===========================================
  Files         115      114        -1     
  Lines        5932     5128      -804     
===========================================
- Hits         4010     4009        -1     
+ Misses       1922     1119      -803     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@emolter emolter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but we should probably do our due diligence and run the JWST regtest suite

@braingram
Copy link
Collaborator Author

Looks good but we should probably do our due diligence and run the JWST regtest suite

Thanks!

Regtests running at: https://github.com/spacetelescope/RegressionTests/actions/runs/12600519431

@braingram
Copy link
Collaborator Author

Regtests show same failures as spacetelescope/jwst#9036 (which is now merged into jwst main).

@braingram braingram merged commit 0d141e5 into spacetelescope:main Jan 3, 2025
22 checks passed
@braingram braingram deleted the remove_schema_editor branch January 3, 2025 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove schema_editor
2 participants