Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address (some) keyword differences #354

Merged
merged 40 commits into from
Nov 19, 2024
Merged

Address (some) keyword differences #354

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
40 commits
Select commit Hold shift + click to select a range
108f4c1
add enum to S_ keywords
braingram Oct 31, 2024
48c0b35
align cal_step titles
braingram Oct 31, 2024
acb39c4
align multispec titles
braingram Oct 31, 2024
228c1db
align oifits titles
braingram Oct 31, 2024
cb70d1c
align DATAEND title
braingram Nov 1, 2024
3d975c1
align DATASTRT title
braingram Nov 1, 2024
d6c088b
align DRPFRMS1 and DRPFRMS3 titles
braingram Nov 1, 2024
a6900f6
align DSETSTRT title, remove enum, kwd says 1-10, no 0
braingram Nov 1, 2024
075427c
allow integer FOCUSPOS
braingram Nov 1, 2024
bbc015d
align GSCENTX GSCENTY titles
braingram Nov 1, 2024
a690fbb
align GS_MUDEC and GS_MURA titles
braingram Nov 1, 2024
c6121b8
align MODULE title
braingram Nov 1, 2024
a208c57
align MRSPRCHN title and enum
braingram Nov 1, 2024
1d900f5
align MU_RA MU_DEC MU_EPOCH titles
braingram Nov 1, 2024
d1a8418
align NRESETS title
braingram Nov 1, 2024
e72705b
align NRIMDTPT title
braingram Nov 1, 2024
15eeb96
align NRSTSTRT title
braingram Nov 1, 2024
3c0ee81
align NUMDSETS title
braingram Nov 1, 2024
112a153
align NUMDTHPT title
braingram Nov 1, 2024
c93ff3d
align NWFSEST and PWFSEET titles
braingram Nov 1, 2024
1c744b6
align PROP_RA and PROP_DEC titles
braingram Nov 1, 2024
bb871b5
align R_ titles
braingram Nov 1, 2024
383ca7a
align RA_REF titles
braingram Nov 1, 2024
dee5412
align SDP_VER title
braingram Nov 1, 2024
2f4d82e
align SPATNSTP title
braingram Nov 1, 2024
107f15a
align SPECNSTP title
braingram Nov 1, 2024
ad3e4ab
align TARG_RA TARG_DEC TARGURA TARUDEC titles
braingram Nov 1, 2024
b13d913
align VISITEND title
braingram Nov 1, 2024
7655fff
align XOFFSET YOFFSET titles
braingram Nov 1, 2024
62516e1
align WTYPE title
braingram Nov 1, 2024
23c29d0
align crpix crval titles
braingram Nov 1, 2024
35a80b8
correct MJD-AVG typo
braingram Nov 1, 2024
4ef1df6
align PCX_X titles
braingram Nov 1, 2024
74a5a66
align REFFRAME title
braingram Nov 1, 2024
263ede1
align SHUTSTA title
braingram Nov 1, 2024
f56fc38
align SLT keyword names
braingram Nov 1, 2024
d692204
align SOURCEID title
braingram Nov 1, 2024
38974ee
align S_REGION title
braingram Nov 1, 2024
1e34809
align WAVSTART WAVEND titles
braingram Nov 1, 2024
3420dc9
add changelog
braingram Nov 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changes/354.bugfix.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Update schema FITS keyword titles to match keyword dictionary.
14 changes: 14 additions & 0 deletions src/stdatamodels/jwst/_kwtool/compare.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,20 @@ def __repr__(self):
},
},
},
("PRIMARY", "FOCUSPOS"): {
"type": {
"dmd": {
"union": {"integer"},
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FOCUSPOS for nirspec is listed as "steps" and of type "integer". For niriss and fg it's listed as "mm" and of type "float".

Adding this expected difference allows it to be listed as a "number" in the datamodel schema.

},
},
},
("PRIMARY", "MRSPRCHN"): {
"enum": {
"dmd": {
"difference": {"ALL"},
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't quite sure about this one but the datamodel schemas list "ALL" but the keyword dictionary does not.

},
},
}
}


Expand Down
Loading