Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unused ignore_version_mismatch #313

Merged
merged 2 commits into from
Aug 20, 2024

Conversation

braingram
Copy link
Collaborator

@braingram braingram commented Aug 7, 2024

ignore_version_mismatch no longer does anything (see asdf-format/asdf#1812) since it was only used by the legacy asdf extension API removed in asdf 3.0.0.

This PR removes all uses of the setting.

There are no uses of ignore_version_mismatch in jwst: https://github.com/search?q=repo%3Aspacetelescope%2Fjwst%20ignore_version_mismatch&type=code

Checklist

  • added entry in CHANGES.rst (either in Bug Fixes or Changes to API)
  • updated relevant tests
  • updated relevant documentation
  • updated relevant milestone(s)
  • added relevant label(s)

Copy link

codecov bot commented Aug 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.21%. Comparing base (83aec51) to head (686125a).
Report is 82 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #313   +/-   ##
=======================================
  Coverage   66.21%   66.21%           
=======================================
  Files         101      101           
  Lines        5402     5402           
=======================================
  Hits         3577     3577           
  Misses       1825     1825           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@braingram braingram force-pushed the ignore_version_mismatch branch from 4f17131 to 686125a Compare August 20, 2024 15:33
Copy link
Collaborator

@nden nden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@braingram braingram merged commit 45b009e into spacetelescope:main Aug 20, 2024
21 checks passed
@braingram braingram deleted the ignore_version_mismatch branch August 20, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants