Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JP-2349: added v2/v3 columns to moving target position table schema #263

Merged
merged 5 commits into from
Aug 21, 2024

Conversation

emolter
Copy link
Contributor

@emolter emolter commented Feb 14, 2024

Resolves JP-2349

Closes spacetelescope/jwst#6507

This PR addresses adding V2/V3 coordinates to the moving target position table schema, in order to provide position information for SLIT and COMPOUND aperture types.

Checklist

  • added entry in CHANGES.rst (either in Bug Fixes or Changes to API)
  • updated relevant tests
  • updated relevant documentation
  • updated relevant milestone(s)
  • added relevant label(s)

Copy link

codecov bot commented Feb 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.21%. Comparing base (debb23c) to head (e3755d8).
Report is 80 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #263   +/-   ##
=======================================
  Coverage   66.21%   66.21%           
=======================================
  Files         101      101           
  Lines        5402     5402           
=======================================
  Hits         3577     3577           
  Misses       1825     1825           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@hbushouse
Copy link
Collaborator

Keeping this in draft form until SDP adds the new columns to the table (in level-1b processing), which likely won't happen until DMS B11.0.

@emolter emolter marked this pull request as ready for review August 20, 2024 13:28
@emolter emolter requested a review from a team as a code owner August 20, 2024 13:28
Copy link
Collaborator

@tapastro tapastro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tapastro tapastro merged commit 7ed9425 into spacetelescope:main Aug 21, 2024
21 checks passed
@emolter emolter deleted the JP-2349 branch August 21, 2024 14:18
@tapastro
Copy link
Collaborator

Note: this PR breaks some JWST regression tests, see: https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/1662/testReport/junit/jwst.regtest/test_nircam_mtimage/_stable_deps__test_nircam_image_moving_target_kwds_with_mt_table_/

Will need to update our regression test data and truth data to accommodate new schema structure before the next stdatamodels release.

@RyleighDavis
Copy link

RyleighDavis commented Sep 25, 2024

It looks like this update to the moving target schema may be causing issues opening MAST files with JWST pipeline version 1.16. After updating the pipeline to version 1.16.0, when attempting to open a moving target uncal file as a datamodel, I now get the error

ValueError: Column names don't match schema. Schema has {'mt_v3', 'mt_v2'}. Data has set()

Is there a work around for this? Or do we need to use a previous pipeline version for moving targets for now?

@tapastro
Copy link
Collaborator

Hi @RyleighDavis , I've filed a workaround here: #329

If you're comfortable installing from the pull (or my branch), that should fix your issues. I think we should be able to get this merged and released in the next couple of days, pending any further issues discovered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Moving Target Position Table Schema to Include V2/V3 Columns
4 participants