Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use PyPI upload workflow from OpenAstronomy #221

Merged
merged 4 commits into from
Oct 20, 2023

Conversation

zacharyburnett
Copy link
Collaborator

Resolves SCSB-108

This PR changes the PyPI upload process to use the OpenAstronomy workflow instead of the STScI one. The workflow in this PR is configured to test the build with each pull request push, and then publish upon an official release.

Checklist

  • added entry in CHANGES.rst (either in Bug Fixes or Changes to API)
  • updated relevant tests
  • updated relevant documentation
  • updated relevant milestone(s)
  • added relevant label(s)

@zacharyburnett zacharyburnett added the no-changelog-entry-needed Trivial change that doesn't need an entry in the change log label Sep 22, 2023
@zacharyburnett zacharyburnett self-assigned this Sep 22, 2023
@zacharyburnett zacharyburnett marked this pull request as ready for review September 22, 2023 17:39
@zacharyburnett zacharyburnett requested a review from a team as a code owner September 22, 2023 17:39
@codecov
Copy link

codecov bot commented Sep 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!.

braingram

This comment was marked as outdated.

Copy link
Collaborator

@braingram braingram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @WilliamJamieson any further changes?

@braingram braingram merged commit ed1c5f6 into spacetelescope:master Oct 20, 2023
21 checks passed
@zacharyburnett zacharyburnett deleted the ci/openastronomy branch October 23, 2023 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog-entry-needed Trivial change that doesn't need an entry in the change log
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants