-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use PyPI upload workflow from OpenAstronomy #221
Merged
braingram
merged 4 commits into
spacetelescope:master
from
zacharyburnett:ci/openastronomy
Oct 20, 2023
Merged
use PyPI upload workflow from OpenAstronomy #221
braingram
merged 4 commits into
spacetelescope:master
from
zacharyburnett:ci/openastronomy
Oct 20, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zacharyburnett
added
the
no-changelog-entry-needed
Trivial change that doesn't need an entry in the change log
label
Sep 22, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know!. |
braingram
reviewed
Sep 25, 2023
zacharyburnett
force-pushed
the
ci/openastronomy
branch
from
September 25, 2023 15:51
9610484
to
be1392e
Compare
braingram
approved these changes
Sep 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM @WilliamJamieson any further changes?
Co-authored-by: William Jamieson <[email protected]>
braingram
force-pushed
the
ci/openastronomy
branch
from
October 20, 2023 13:50
be1392e
to
0ea5cd2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves SCSB-108
This PR changes the PyPI upload process to use the OpenAstronomy workflow instead of the STScI one. The workflow in this PR is configured to test the build with each pull request push, and then publish upon an official release.
Checklist
added entry inCHANGES.rst
(either inBug Fixes
orChanges to API
)updated relevant testsupdated relevant documentation