fix rebuild_fits_rec_dtype for shaped columns #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
braingram
force-pushed
the
rebuild_fits_rec_dtype_shaped
branch
from
e860705 to
a098eed
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #213 +/- ##
==========================================
+ Coverage 64.68% 64.70% +0.01%
==========================================
Files 102 102
Lines 5663 5666 +3
==========================================
+ Hits 3663 3666 +3
Misses 2000 2000 ☔ View full report in Codecov by Sentry. |
braingram
force-pushed
the
rebuild_fits_rec_dtype_shaped
branch
from
a098eed to
de4f05c
Compare
braingram
force-pushed
the
rebuild_fits_rec_dtype_shaped
branch
from
de4f05c to
208c876
Compare
braingram
force-pushed
the
rebuild_fits_rec_dtype_shaped
branch
from
208c876 to
bf4056d
Compare
braingram
force-pushed
the
rebuild_fits_rec_dtype_shaped
branch
from
bf4056d to
e8a83fd
Compare
tapastro
approved these changes
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
stdatamodels.util.rebuild_fits_rec_dtypeappears to incorrectly handle unsigned integer columns with shapes. This PR updatesrebuild_fits_rec_dtypeand adds tests for this error.Closes #206
Regression tests run with no errors: https://plwishmaster.stsci.edu:8081/blue/organizations/jenkins/RT%2FJWST-Developers-Pull-Requests/detail/JWST-Developers-Pull-Requests/963/pipeline
Checklist
CHANGES.rst(either inBug FixesorChanges to API)