Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert #314 and #322 #323

Closed
wants to merge 1 commit into from

Conversation

braingram
Copy link
Collaborator

@braingram braingram commented Dec 13, 2024

#314 and #322 are causing jwst test failures. This PR reverts #314 and #322 to allow ongoing jwst and stcal work to be tested.

Tasks

  • update or add relevant tests
  • update relevant docstrings and / or docs/ page
  • Does this PR change any API used downstream? (if not, label with no-changelog-entry-needed)
    • write news fragment(s) in changes/: echo "changed something" > changes/<PR#>.<changetype>.rst (see below for change types)
    • run regression tests with this branch installed ("git+https://github.com/<fork>/stcal@<branch>")
news fragment change types...
  • changes/<PR#>.apichange.rst: change to public API
  • changes/<PR#>.bugfix.rst: fixes an issue
  • changes/<PR#>.general.rst: infrastructure or miscellaneous change

Copy link

codecov bot commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.88%. Comparing base (728b877) to head (9364f29).
Report is 3 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #323       +/-   ##
===========================================
+ Coverage   29.56%   86.88%   +57.32%     
===========================================
  Files          37       49       +12     
  Lines        8332     8937      +605     
===========================================
+ Hits         2463     7765     +5302     
+ Misses       5869     1172     -4697     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@braingram braingram marked this pull request as ready for review December 13, 2024 22:16
@braingram braingram requested a review from a team as a code owner December 13, 2024 22:16
melanieclarke
melanieclarke previously approved these changes Dec 13, 2024
@melanieclarke melanieclarke dismissed their stale review December 13, 2024 22:23

Downstream failures

@braingram
Copy link
Collaborator Author

braingram commented Dec 14, 2024

Downstream tests are failing since the jwst/romancal downstream had/has stcal@main as a dependency which has gwcs@master as a dependency. This caused gwcs@master to be installed (even though it's not a dependency in this PR) which is the root of the changes leading to test failures. I'm confident (but not certain) that if this PR is merged into stcal@main the tests would no longer pick up gwcs@master and not fail. This does highlight an issue with our test setup here and makes it unsuitable for judging this PR.

@braingram braingram closed this Dec 16, 2024
@braingram braingram deleted the revert_314_and_322 branch December 16, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants