Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JP-3805: Change prior-group flagging to DO_NOT_USE instead of SATURATION #321

Merged
merged 9 commits into from
Dec 20, 2024

Conversation

drlaw1558
Copy link
Contributor

This PR addresses the issue raised by JP-3805 wherein the flagging of saturation in group-averaged data by estimating the counts in each frame can bias the finding and flagging of snowballs downstream. This does so by changing the flagging of such 'pre-saturation' to use DO_NOT_USE instead of SATURATED.

Tasks

  • update or add relevant tests
  • update relevant docstrings and / or docs/ page
  • Does this PR change any API used downstream? (if not, label with no-changelog-entry-needed)
    • write news fragment(s) in changes/: echo "changed something" > changes/<PR#>.<changetype>.rst (see below for change types)
    • run regression tests with this branch installed ("git+https://github.com/<fork>/stcal@<branch>")
news fragment change types...
  • changes/<PR#>.apichange.rst: change to public API
  • changes/<PR#>.bugfix.rst: fixes an issue
  • changes/<PR#>.general.rst: infrastructure or miscellaneous change

Copy link

codecov bot commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.57%. Comparing base (8f0186b) to head (35726e9).
Report is 11 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #321      +/-   ##
==========================================
+ Coverage   28.69%   29.57%   +0.88%     
==========================================
  Files          31       36       +5     
  Lines        7821     7949     +128     
==========================================
+ Hits         2244     2351     +107     
- Misses       5577     5598      +21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@drlaw1558 drlaw1558 marked this pull request as ready for review November 27, 2024 19:44
@drlaw1558 drlaw1558 requested a review from a team as a code owner November 27, 2024 19:44
@melanieclarke
Copy link
Contributor

@tapastro - do we want this in build 11.2?

@tapastro
Copy link
Collaborator

After some work by @schlafly to relax romancal tests which allow this PR to pass testing, and jwst RT passing: https://github.com/spacetelescope/RegressionTests/actions/runs/12432943298

We can merge this. I will file a JP ticket to track further investigation of the snowball code, which will hopefully lead to a PR with changes to snowball code and a reversion of this update.

@tapastro tapastro self-requested a review December 20, 2024 17:35
@tapastro tapastro merged commit 9114b5a into spacetelescope:main Dec 20, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants