-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JP-3805: Change prior-group flagging to DO_NOT_USE instead of SATURATION #321
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #321 +/- ##
==========================================
+ Coverage 28.69% 29.57% +0.88%
==========================================
Files 31 36 +5
Lines 7821 7949 +128
==========================================
+ Hits 2244 2351 +107
- Misses 5577 5598 +21 ☔ View full report in Codecov by Sentry. |
@tapastro - do we want this in build 11.2? |
xfail unit test, add coverage for this change
After some work by @schlafly to relax romancal tests which allow this PR to pass testing, and jwst RT passing: https://github.com/spacetelescope/RegressionTests/actions/runs/12432943298 We can merge this. I will file a JP ticket to track further investigation of the snowball code, which will hopefully lead to a PR with changes to snowball code and a reversion of this update. |
This PR addresses the issue raised by JP-3805 wherein the flagging of saturation in group-averaged data by estimating the counts in each frame can bias the finding and flagging of snowballs downstream. This does so by changing the flagging of such 'pre-saturation' to use DO_NOT_USE instead of SATURATED.
Tasks
docs/
pageno-changelog-entry-needed
)changes/
:echo "changed something" > changes/<PR#>.<changetype>.rst
(see below for change types)"git+https://github.com/<fork>/stcal@<branch>"
)jwst
regression testromancal
regression testnews fragment change types...
changes/<PR#>.apichange.rst
: change to public APIchanges/<PR#>.bugfix.rst
: fixes an issuechanges/<PR#>.general.rst
: infrastructure or miscellaneous change