JP-3708, JP-3771, JP-3791

changes/318.bugfix.rst

@@ -0,0 +1,5 @@
+For `ramp_fitting`, the `CRMAG` element was not originally implemented in
+the C-extension for ramp fitting.  It is now implemented.  A bug in the read
+noise recalculation for CHARGELOSS when using the multiprocessing option has
+been fixed.  Further, in `JWST` regression tests have been added to test for
+multiprocessing to ensure testing for anything that could affect multiprocessing.

src/stcal/ramp_fitting/ols_fit.py

@@ -46,10 +46,6 @@
     gain_2d : ndarray
         gain for all pixels
 
-    algorithm : str
-        'OLS' specifies that ordinary least squares should be used;
-        'GLS' specifies that generalized least squares should be used.
-
     weighting : str
         'optimal' specifies that optimal weighting should be used;
          currently the only weighting supported.
@@ -214,6 +210,11 @@
     """
     # Create output arrays for each output tuple.  The input ramp data and
     # slices are needed for this.
+    for result in pool_results:
+        image_slice, integ_slice, opt_slice = result
+        if image_slice is None or integ_slice is None:
+            return None, None, None
+
     image_info, integ_info, opt_info = create_output_info(ramp_data, pool_results, save_opt)
 
     # Loop over the slices and assemble each slice into the main return arrays.
@@ -570,6 +571,14 @@
     ramp_data_slice.flags_saturated = ramp_data.flags_saturated
     ramp_data_slice.flags_no_gain_val = ramp_data.flags_no_gain_val
     ramp_data_slice.flags_unreliable_slope = ramp_data.flags_unreliable_slope
+    ramp_data_slice.flags_chargeloss = ramp_data.flags_chargeloss
+
+    # For possible CHARGELOSS flagging.
+    if ramp_data.orig_gdq is not None:
+        ogdq = ramp_data.orig_gdq[:, :, start_row : start_row + nrows, :].copy()
+        ramp_data_slice.orig_gdq = ogdq
+    else:
+        ramp_data_slice.orig_gdq = None
 
     # Slice info
     ramp_data_slice.start_row = start_row