Revert "AL-875: Add memory saving options to compute_weight_threshold sigma_clip call" #315
Conversation
… sigma_c…" This reverts commit 5299646.
There was a problem hiding this comment.
This PR is causing a failure in a single pixel of a _median product on the JWST side, which is an intermediate product. My opinion is there is no need to revert this based on the JWST regression tests alone.
I'm approving this anyway because it sounds like the Romancal team is still not sure whether the two failing regression tests are a cause for concern, and they'd like this not to be merged until they can figure that out.
There was a problem hiding this comment.
Approving. FWIW, I don't think this is a major issue on the Roman side either, and I'm not pushing hard to remove this change on the basis of the romancal regression tests. We could go ahead and okify those. But I understand that we didn't intend to cause changes due to this PR and so may want to revisit it.
…hreshold sigma_clip call" (spacetelescope#315)" This reverts commit 63d5280, reversing changes made to 5299646.
…hreshold sigma_clip call" (spacetelescope#315)" This reverts commit 63d5280, reversing changes made to 5299646.
Reverts #312
The reverted PR is causing regression test failures due in part to np.mean on a masked float32 array (which was the pre-PR behavior) producing a different result compared to a np.mean on a float32 array.