Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JP-3771 and JP-3791: Ramp Fitting Multiprocessing Regression Testing and Read Noise Variance #313

Conversation

kmacdonald-stsci
Copy link
Collaborator

Resolves JP-3771
Resolves JP-3771

This PR addresses adding ramp fitting and jump step multiprocessing regression test. The ramp fit multiprocessing regression test revealed a logical bug in the way the read noise variance gets recalculated due to the CHARGELOSS flagging. The original group DQ flagging array, nor the CHARGELOSS flag, were being properly copied to each data sliced used to divide the data in preparation for multiprocessing.

Tasks

  • update or add relevant tests
  • update relevant docstrings and / or docs/ page
  • Does this PR change any API used downstream? (if not, label with no-changelog-entry-needed)
    • write news fragment(s) in changes/: echo "changed something" > changes/<PR#>.<changetype>.rst (see below for change types)
    • run regression tests with this branch installed ("git+https://github.com/<fork>/stcal@<branch>")
news fragment change types...
  • changes/<PR#>.apichange.rst: change to public API
  • changes/<PR#>.bugfix.rst: fixes an issue
  • changes/<PR#>.general.rst: infrastructure or miscellaneous change

Copy link

codecov bot commented Oct 29, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 86.28%. Comparing base (60bd3b8) to head (20388ec).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
src/stcal/ramp_fitting/ols_fit.py 60.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #313      +/-   ##
==========================================
+ Coverage   86.21%   86.28%   +0.07%     
==========================================
  Files          47       49       +2     
  Lines        8812     8875      +63     
==========================================
+ Hits         7597     7658      +61     
- Misses       1215     1217       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kmacdonald-stsci
Copy link
Collaborator Author

Closing to fix multiprocessing bug in the optional results product.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant