Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull common parts of skymatch from romancal and jwst into stcal #310

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

WilliamJamieson
Copy link
Collaborator

@WilliamJamieson WilliamJamieson commented Oct 17, 2024

This PR pulls the common parts of skymatch from romancal and jwst into stcal to be shared.

Note, no tests are included because it is well tested by the step tests in both romancal and jwst.

Tasks

  • update or add relevant tests
  • update relevant docstrings and / or docs/ page
  • Does this PR change any API used downstream? (if not, label with no-changelog-entry-needed)
    • write news fragment(s) in changes/: echo "changed something" > changes/<PR#>.<changetype>.rst (see below for change types)
    • run regression tests with this branch installed ("git+https://github.com/<fork>/stcal@<branch>")
news fragment change types...
  • changes/<PR#>.apichange.rst: change to public API
  • changes/<PR#>.bugfix.rst: fixes an issue
  • changes/<PR#>.general.rst: infrastructure or miscellaneous change

Copy link

codecov bot commented Oct 17, 2024

Codecov Report

Attention: Patch coverage is 69.57774% with 317 lines in your changes missing coverage. Please review.

Project coverage is 85.02%. Comparing base (8f0186b) to head (cfaf7eb).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/stcal/skymatch/skyimage.py 61.09% 270 Missing ⚠️
src/stcal/skymatch/skymatch.py 83.90% 47 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #310       +/-   ##
===========================================
+ Coverage   28.69%   85.02%   +56.33%     
===========================================
  Files          31       53       +22     
  Lines        7821    10012     +2191     
===========================================
+ Hits         2244     8513     +6269     
+ Misses       5577     1499     -4078     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant