Python 3.13 preparation for ramp fitting. #303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here is the regression testing for this PR: https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/1778/ |
kmacdonald-stsci
requested review from
schlafly,
melanieclarke,
tapastro and
braingram
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #303 +/- ##
=======================================
Coverage 86.21% 86.21%
=======================================
Files 47 47
Lines 8812 8812
=======================================
Hits 7597 7597
Misses 1215 1215 ☔ View full report in Codecov by Sentry. |
braingram
approved these changes
Oct 9, 2024
There was a problem hiding this comment.
Thanks!
I rebased #300 to include these changes and the python 3.13 run passes with the changes in this PR:
https://github.com/spacetelescope/stcal/actions/runs/11257779409/job/31302843924?pr=300
|
Closing as a duplicate PR for #300 |
…nd exception in the C-extension in python 3.13.
… for ramp fitting. It is not to update all of STCAL for python 3.13.
kmacdonald-stsci
force-pushed
the
py313
branch
from
e7fee73 to
ae6a7c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR prepares the ramp fitting C-extension for the upgrade to python 3.13. This version of python added an exception to the
PyLong_AsLongfunction if thePyObjectpassed to it isNoneType. Now for two attributes ofRampDatathat can beNoneTypea check needs to be put in place guard against this exception. The other attributes ofRampDatathat are expected to be integer type should never beNoneType, so should raise an exception if they are.Tasks
docs/pageno-changelog-entry-needed)changes/:echo "changed something" > changes/<PR#>.<changetype>.rst(see below for change types)"git+https://github.com/<fork>/stcal@<branch>")jwstregression testromancalregression testnews fragment change types...
changes/<PR#>.apichange.rst: change to public APIchanges/<PR#>.bugfix.rst: fixes an issuechanges/<PR#>.general.rst: infrastructure or miscellaneous change