Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SCSB-145] require Python 3.10 #250

Merged
merged 4 commits into from
Mar 18, 2024

Conversation

zacharyburnett
Copy link
Collaborator

resolves SCSB-145

propagate Astropy's deprecation of Python 3.9 to downstream packages

Note

this PR was generated automatically by batchpr 🤖

@zacharyburnett zacharyburnett requested a review from a team as a code owner March 14, 2024 18:13
Copy link

codecov bot commented Mar 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.86%. Comparing base (41259f3) to head (520e17a).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #250      +/-   ##
==========================================
- Coverage   85.90%   85.86%   -0.04%     
==========================================
  Files          35       35              
  Lines        6557     6574      +17     
==========================================
+ Hits         5633     5645      +12     
- Misses        924      929       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zacharyburnett zacharyburnett marked this pull request as ready for review March 15, 2024 17:14
@github-actions github-actions bot added documentation Improvements or additions to documentation automation testing labels Mar 15, 2024
@zacharyburnett zacharyburnett enabled auto-merge (squash) March 15, 2024 19:59
'PERF', # Perflint (performance linting)
'LOG',
'RUF', # ruff specific checks
"F",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of the comments that got deleted here are obviously not necessary for the functioning of the file, but aren't they kind of useful to keep around for documentation purposes?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I apologize, I overlooked your comments on Friday when merging. These were stripped by the auto-formatter and I didn't get to restore them; fixed in 92be82d


[tool.repo-review]
ignore = [
"GH200", # Use dependabot
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, isn't it of some use to maintainers to retain these comments?

@zacharyburnett zacharyburnett merged commit c43b9ef into spacetelescope:main Mar 18, 2024
24 of 25 checks passed
@zacharyburnett zacharyburnett deleted the scsb145 branch March 18, 2024 12:38
zacharyburnett added a commit that referenced this pull request Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants