-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SCSB-145] require Python 3.10 #250
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #250 +/- ##
==========================================
- Coverage 85.90% 85.86% -0.04%
==========================================
Files 35 35
Lines 6557 6574 +17
==========================================
+ Hits 5633 5645 +12
- Misses 924 929 +5 ☔ View full report in Codecov by Sentry. |
'PERF', # Perflint (performance linting) | ||
'LOG', | ||
'RUF', # ruff specific checks | ||
"F", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All of the comments that got deleted here are obviously not necessary for the functioning of the file, but aren't they kind of useful to keep around for documentation purposes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I apologize, I overlooked your comments on Friday when merging. These were stripped by the auto-formatter and I didn't get to restore them; fixed in 92be82d
|
||
[tool.repo-review] | ||
ignore = [ | ||
"GH200", # Use dependabot |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Again, isn't it of some use to maintainers to retain these comments?
This reverts commit c43b9ef.
resolves SCSB-145
propagate Astropy's deprecation of Python 3.9 to downstream packages
Note
this PR was generated automatically by
batchpr
🤖