JP-3448: Always flag at least one group when showers are detected

[mwregan2]

Resolves JP-3448

Closes spacetelescope/jwst#8030

This PR addresses the problem that the shower flagging is not including the flagging of the primary shower as a minimum. The code was updated to match the input parameter which is the time to flag groups after the primary shower. The current default values and code lead to no flagging in MIRI slow mode.

Checklist

• added entry in CHANGES.rst (either in Bug Fixes or Changes to API)
• updated relevant tests
• updated relevant documentation
• updated relevant milestone(s)
• added relevant label(s)

[codecov]

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (dfa9a50) 85.94% compared to head (a62076e) 85.98%.

Files	Patch %	Lines
src/stcal/jump/jump.py	90.90%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #237      +/-   ##
==========================================
+ Coverage   85.94%   85.98%   +0.04%     
==========================================
  Files          35       35              
  Lines        6523     6542      +19     
==========================================
+ Hits         5606     5625      +19     
  Misses        917      917              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[mwregan2]

Will do. I need to double check something first.

…

________________________________ From: Howard Bushouse ***@***.***> Sent: Thursday, January 4, 2024 8:37:19 AM To: spacetelescope/stcal Cc: Michael Regan; Mention Subject: Re: [spacetelescope/stcal] Always_flag_at_least_one_shower_grp (PR #237) @mwregan2<https://urldefense.com/v3/__https://github.com/mwregan2__;!!CrWY41Z8OgsX0i-WU-0LuAcUu2o!0Fk3orxs7bDL--prRz7X5lsoCe3qMcMYw9cPGHhjUJx53wbKzRdZpUyemId1fsR3BbCJrEcgHrlVHJbQyrsuBGw$> Still waiting for review comments to be addressed. — Reply to this email directly, view it on GitHub<https://urldefense.com/v3/__https://github.com/spacetelescope/stcal/pull/237*issuecomment-1877107626__;Iw!!CrWY41Z8OgsX0i-WU-0LuAcUu2o!0Fk3orxs7bDL--prRz7X5lsoCe3qMcMYw9cPGHhjUJx53wbKzRdZpUyemId1fsR3BbCJrEcgHrlVHJbQd2qoDg0$>, or unsubscribe<https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/AF6KJLV42CHZ7IWS4OJREOTYM2WA7AVCNFSM6AAAAABBF2OWCOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNZXGEYDONRSGY__;!!CrWY41Z8OgsX0i-WU-0LuAcUu2o!0Fk3orxs7bDL--prRz7X5lsoCe3qMcMYw9cPGHhjUJx53wbKzRdZpUyemId1fsR3BbCJrEcgHrlVHJbQHwjxLFg$>. You are receiving this because you were mentioned.Message ID: ***@***.***>

[hbushouse]

I tried fixing obvious errors (like mismatching argument names) to get this PR to pass CI tests, but it's still failing CI's with both differences in unit test results and a real error "UnboundLocalError: cannot access local variable 'total_showers' where it is not associated with a value". So something still needs fixing in the basic code.

[hbushouse]

Looks good now and all CI tests are passing.