Add concurrency cancels to build and weekly cron #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
This way pushing new commits to a PR auto cancels the old jobs.
WilliamJamieson
force-pushed
the
bugfix/concurency
branch
from
0ffbf71 to
f4129b0
Compare
kmacdonald-stsci
approved these changes
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have noticed that pushing commits to branches with open PRs can cause huge delays in the build job completing. This is because there are no concurrency checks, meaning all the previously triggered jobs (by other pushes) all run to completion. I also noticed this for the weekly job, which can by special request be run on a PR too.
Checklist
CHANGES.rst(either inBug FixesorChanges to API)