Resolve some bugs with the jump fitting algorithm #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WilliamJamieson
requested review from
schlafly
and removed request for
a team
WilliamJamieson
force-pushed
the
bugfix/jump_bugs
branch
from
97b6f63 to
ba5589c
Compare
schlafly
reviewed
Nov 6, 2023
| @@ -24,7 +24,7 @@ | |||
| READ_NOISE = np.float32(5) | |||
|
|
|||
| # Set a value for jumps which makes them obvious relative to the normal flux | |||
| JUMP_VALUE = 10_000 | |||
| JUMP_VALUE = 1_000 | |||
There was a problem hiding this comment.
Looks good to me. I wasn't sure if this one was intentional.
There was a problem hiding this comment.
This had no visible effect on the results
schlafly
approved these changes
Nov 6, 2023
tests/test_jump_cas22.py
Outdated
| @@ -447,7 +452,7 @@ def test_fit_ramps(detector_data, use_jump, use_dq): | |||
|
|
|||
| assert use_dq # sanity check that this branch is only encountered when use_dq = True | |||
|
|
|||
| chi2 /= np.sum(okay) | |||
| chi2 /= (np.sum(okay) + excess) | |||
There was a problem hiding this comment.
I don't think it makes a difference, but I don't think I expected the "excess" to make an appearence here, since those cases don't contribute to chi^2 above on line 444.
There was a problem hiding this comment.
It actually should be be a difference not a sum, but you are right, it makes no difference
There was a problem hiding this comment.
Yup, would make sense subtracted, thanks.
Codecov ReportAttention:
📢 Thoughts on this report? Let us know! |
WilliamJamieson
force-pushed
the
bugfix/jump_bugs
branch
from
ba5589c to
7c0bd1e
Compare
kmacdonald-stsci
approved these changes
Nov 6, 2023
WilliamJamieson
added a commit
to WilliamJamieson/stcal
that referenced
this pull request
Nov 14, 2023
if jumps are correctly identified This checks if jumps are correctly identified, resolving some lingering test issues from spacetelescope#227
5 tasks
WilliamJamieson
added a commit
to WilliamJamieson/stcal
that referenced
this pull request
Nov 14, 2023
if jumps are correctly identified This checks if jumps are correctly identified, resolving some lingering test issues from spacetelescope#227
WilliamJamieson
added a commit
to WilliamJamieson/stcal
that referenced
this pull request
Nov 16, 2023
if jumps are correctly identified This checks if jumps are correctly identified, resolving some lingering test issues from spacetelescope#227
WilliamJamieson
added a commit
to WilliamJamieson/stcal
that referenced
this pull request
Nov 21, 2023
if jumps are correctly identified This checks if jumps are correctly identified, resolving some lingering test issues from spacetelescope#227
WilliamJamieson
added a commit
to WilliamJamieson/stcal
that referenced
this pull request
Feb 13, 2024
if jumps are correctly identified This checks if jumps are correctly identified, resolving some lingering test issues from spacetelescope#227
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes some adjustments to the jump detection algorithm so that it exactly detects the jumps detected in the simulated data.
Checklist
CHANGES.rst(either inBug FixesorChanges to API)