Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding stcal-alignment sub-package. #196

Merged
merged 133 commits into from
Oct 6, 2023
Merged

Adding stcal-alignment sub-package. #196

merged 133 commits into from
Oct 6, 2023

Conversation

mairanteodoro
Copy link
Collaborator

@mairanteodoro mairanteodoro commented Aug 23, 2023 •
edited
Loading

This PR addresses the implementation of the common-code sub-package alignment.

Note
The downstream job for romancal will succeed once PR#919 has been approved.

Checklist

  • added entry in CHANGES.rst (either in Bug Fixes or Changes to API)
  • updated relevant tests
  • updated relevant documentation
  • updated relevant milestone(s)
  • added relevant label(s)

mairanteodoro and others added 30 commits June 29, 2023 11:30
@mairanteodoro
Update .gitignore file.
856ffba
@mairanteodoro
Create subpackage and initial module structure.
a4fed92
@mairanteodoro
Add methods to alignment.util.
f57851a
@mairanteodoro
Update .gitignore.
556279d
@mairanteodoro
Remove unused modules.
1a3628e
@mairanteodoro
Clean module.
a09e0cb
@mairanteodoro
Update .gitignore.
9ab2e44
@mairanteodoro
Add methods necessary for resample.
9441dd4
@mairanteodoro
Small changes to accommodate both JWST and RST datamodels.
f0013aa
@mairanteodoro
Add CHANGES.rst entry.
66ea089
@mairanteodoro
Add PR number to CHANGES.rst entry.
48e3d60
@nden @mairanteodoro
use protocols
66ba3fe
@nden @mairanteodoro
temp
3906abf
@nden @mairanteodoro
add dependencies
3467f81
@nden @mairanteodoro
add CI testing to alignment branch
13c342f
@nden @mairanteodoro
add CI testing to alignment branch
42423d3
@nden @mairanteodoro
fix test
b8b8cc0
@mwregan2 @hbushouse @mairanteodoro
Add setting of number_extended_events (#178)
fa86a3e 
* Add setting of number_extended_events

This was not being set when in single processing mode.

* Update CHANGES.rst

* Update CHANGES.rst

* Update test_jump.py

---------

Co-authored-by: Howard Bushouse <[email protected]>
@mairanteodoro
Rename variables with FITS keywords names.
0eea0e5
@mairanteodoro
Style reformating.
7c136a7
@mairanteodoro
Update docs to include stcal.alignment.
cc7d689
@mairanteodoro
Revert "Rename variables with FITS keywords names."
f4f379d 
This reverts commit 0eea0e5.
@mairanteodoro
Updates to address most comments.
afa9e7a
@mairanteodoro
Fix misplaced comment.
0cd3621
@mairanteodoro
Code refactoring and additional unit test.
a8839a9
@mairanteodoro
Silencing style check warning F403.
47f785b
@mairanteodoro
Small style refactoring.
424fd38
@mairanteodoro
Set minimum asdf version.
d67e0b9
@mairanteodoro
Update matplotlib's inventory URL.
1229f02
@mairanteodoro
Set lower version for gwcs.
500479a
@mairanteodoro mairanteodoro mentioned this pull request Sep 28, 2023
Merged
5 tasks
zacharyburnett and others added 4 commits September 28, 2023 16:39
@zacharyburnett @mairanteodoro
use PyPI upload workflow from OpenAstronomy (#214)
2626396 
* use OpenAstronomy PyPI upload workflow

* try copying Astropy's config (may need to omit arm entries)

* force CPython

* fix upload event filter
@zacharyburnett @mairanteodoro
download WebbPSF data for downstream tests
af275b0
@zacharyburnett @mairanteodoro
pass env var
5c4dff9
@mairanteodoro
Merge branch 'main' into stcal-alignment
7735528
@mairanteodoro mairanteodoro marked this pull request as ready for review September 29, 2023 14:07
nden
nden requested changes Sep 30, 2023
View reviewed changes
Copy link
Collaborator

@nden nden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs a rebase - some of the changes in CHANGES.rst do not appear in the version on master. Also I left a couple internal comments.

.github/workflows/ci.yml Outdated Show resolved Hide resolved
docs/conf.py Outdated Show resolved Hide resolved
@mairanteodoro mairanteodoro requested a review from nden October 5, 2023 19:34
nden
nden requested changes Oct 6, 2023
View reviewed changes
Copy link
Collaborator

@nden nden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This still does not look quite right as there are changes on main that are duplicated here. Can you do a rebase and move the change log?

CHANGES.rst Outdated Show resolved Hide resolved
@mairanteodoro mairanteodoro requested a review from nden October 6, 2023 19:45
nden
nden approved these changes Oct 6, 2023
View reviewed changes
Copy link
Collaborator

@nden nden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mairanteodoro mairanteodoro merged commit 2251433 into main Oct 6, 2023
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kmacdonald-stsci kmacdonald-stsci kmacdonald-stsci approved these changes

@nden nden nden approved these changes

@s-goldman s-goldman Awaiting requested review from s-goldman

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation installation no-changelog-entry-needed testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mairanteodoro @nden @kmacdonald-stsci @mwregan2 @s-goldman @zacharyburnett