JP-3638: Flag asymmetrical snowballs (#261)

* Update jump.py

* fixes

* updates

* Update jump.py

* Update CHANGES.rst

* cleanup

* Update test_jump.py

* address comments

* Update CHANGES.rst

CHANGES.rst

@@ -13,7 +13,11 @@ Changes to API
 
 Bug Fixes
 ---------
-
+jump
+~~~~
+- Flag asymmetrical snowballs that are missed by the current code (JP-3638). This was changed to
+  not require that the center of the snowball jump ellipse is a saturated
+  pixel. [#261]
 - 
 
 1.7.1 (2024-05-21)

src/stcal/jump/jump.py

@@ -591,6 +591,12 @@ def flag_large_events(
             prev_sat = np.bitwise_and(prev_gdq, sat_flag)
             not_prev_sat = np.logical_not(prev_sat)
             new_sat = current_sat * not_prev_sat
+            if group < ngrps - 1:
+                next_gdq = gdq[integration, group + 1, :, :]
+                next_sat = np.bitwise_and(next_gdq, sat_flag)
+                not_current_sat = np.logical_not(current_sat)
+                next_new_sat = next_sat * not_current_sat
+            next_sat_ellipses = find_ellipses(next_new_sat, sat_flag, min_sat_area)
             sat_ellipses = find_ellipses(new_sat, sat_flag, min_sat_area)
             # find the ellipse parameters for jump regions
             jump_ellipses = find_ellipses(gdq[integration, group, :, :], jump_flag, min_jump_area)
@@ -603,6 +609,7 @@ def flag_large_events(
                     group,
                     jump_ellipses,
                     sat_ellipses,
+                    next_sat_ellipses,
                     low_threshold,
                     high_threshold,
                     min_sat_radius_extend,
@@ -807,6 +814,7 @@ def make_snowballs(
     group,
     jump_ellipses,
     sat_ellipses,
+    next_sat_ellipses,
     low_threshold,
     high_threshold,
     min_sat_radius,
@@ -822,29 +830,19 @@ def make_snowballs(
     snowballs = []
     num_groups = gdq.shape[1]
     for jump in jump_ellipses:
-        # center of jump should be saturated
-        jump_center = jump[0]
-        if (
-            # if center of the jump ellipse is not saturated in this group and is saturated in
-            # the next group add the jump ellipse to the snowball list
-            group < (num_groups - 1)
-            and gdq[integration, group + 1, round(jump_center[1]), round(jump_center[0])] == sat_flag
-            and gdq[integration, group, round(jump_center[1]), round(jump_center[0])] != sat_flag
-        ) or (
+        if near_edge(jump, low_threshold, high_threshold):
             # if the jump ellipse is near the edge, do not require saturation in the
             # center of the jump ellipse
-            near_edge(jump, low_threshold, high_threshold)
-        ):
             snowballs.append(jump)
         else:
             for sat in sat_ellipses:
-                # center of saturation is within the enclosing jump rectangle
-                if (
-                    point_inside_ellipse(sat[0], jump)
-                    and gdq[integration, group, round(jump_center[1]), round(jump_center[0])] == sat_flag
-                    and jump not in snowballs
-                ):
+                if ((point_inside_ellipse(sat[0], jump) and jump not in snowballs)):
                     snowballs.append(jump)
+            if group < num_groups - 1:
+                # Is there saturation inside the jump in the next group?
+                for next_sat in next_sat_ellipses:
+                    if ((point_inside_ellipse(next_sat[0], jump)) and jump not in snowballs):
+                        snowballs.append(jump)
     # extend the saturated ellipses that are larger than the min_sat_radius
     gdq[integration, :, :, :], persist_jumps[integration, :, :] = extend_saturation(
         gdq[integration, :, :, :],
@@ -863,9 +861,9 @@ def make_snowballs(
 
 def point_inside_ellipse(point, ellipse):
     delta_center = np.sqrt((point[0] - ellipse[0][0]) ** 2 + (point[1] - ellipse[0][1]) ** 2)
-    minor_axis = min(ellipse[1][0], ellipse[1][1])
+    major_axis = max(ellipse[1][0], ellipse[1][1])
 
-    return delta_center < minor_axis
+    return delta_center < major_axis
 
 
 def near_edge(jump, low_threshold, high_threshold):

tests/test_jump.py

@@ -526,42 +526,27 @@ def test_inside_ellipse5():
     ellipse = ((0, 0), (1, 2), -10)
     point = (1, 0.6)
     result = point_inside_ellipse(point, ellipse)
-    assert not result
+    assert result
 
 
 def test_inside_ellipse4():
     ellipse = ((0, 0), (1, 2), 0)
     point = (1, 0.5)
     result = point_inside_ellipse(point, ellipse)
-    assert not result
+    assert result
 
+def test_inside_ellipse6():
+    ellipse = ((0, 0), (1, 2), 0)
+    point = (3, 0.5)
+    result = point_inside_ellipse(point, ellipse)
+    assert not result
 
 def test_inside_ellipes5():
     point = (1110.5, 870.5)
     ellipse = ((1111.0001220703125, 870.5000610351562), (10.60660171508789, 10.60660171508789), 45.0)
     result = point_inside_ellipse(point, ellipse)
     assert result
 
-@pytest.mark.skip(" used for local testing")
-def test_flag_persist_groups():
-#   gdq = fits.getdata("persistgdq.fits")
-    gdq = np.zeros(shape=(2,2,2,2))
-    print(gdq.shape[0])
-    gdq = gdq[:, 0:10, :, :]
-    total_snowballs = flag_large_events(
-        gdq,
-        DQFLAGS["JUMP_DET"],
-        DQFLAGS["SATURATED"],
-        min_sat_area=1,
-        min_jump_area=6,
-        expand_factor=1.9,
-        edge_size=0,
-        sat_required_snowball=True,
-        min_sat_radius_extend=2.5,
-        sat_expand=1.1,
-        mask_persist_grps_next_int=True,
-        persist_grps_flagged=0)
-
 def test_calc_num_slices():
     n_rows = 20
     max_available_cores = 10