Merge pull request #236 from spacetelescope/loaders

fix scatterplot and histogram bugs
spacetelescope · Dec 9, 2016 · 131dadd · 131dadd
2 parents f03bc96 + 2e0a6e3
commit 131dadd
Showing 1 changed file with 13 additions and 6 deletions.
diff --git a/specviz/core/plots.py b/specviz/core/plots.py
@@ -192,13 +192,20 @@ def update(self, autoscale=False):
             data = self.layer.data.compressed().value
             uncert = self.layer.raw_uncertainty.compressed().value
 
-        disp = np.append(disp, disp[-1]) if self.mode is 'histogram' else disp
-        # data = data[:-1] if self.mode is 'histogram' else data
+        #-- Changes specific for scatter plot rendering
+        symbol = 'o' if self.mode == 'scatter' else None
+        pen = None if self.mode == 'scatter' else self.pen
 
-        self._plot.setData(disp, data, symbol='o' if self.mode is 'scatter' else None,
-                           stepMode=True if self.mode is 'histogram' else False,
-                           pen=None if self.mode is 'scatter' else self.pen)
+        #-- changes specific for histrogram rendering
+        stepMode = True if self.mode == 'histogram' else False
+        disp = np.append(disp, disp[-1]) if self.mode == 'histogram' else disp
+
+        self._plot.setData(disp,
+                           data,
+                           symbol=symbol,
+                           stepMode=stepMode,
+                           pen=pen)
 
         if self.error is not None:
-            self.error.setData(x=disp[:-1] if self.mode is 'histogram' else disp,
+            self.error.setData(x=disp[:-1] if self.mode == 'histogram' else disp,
                                y=data, height=uncert)