Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix/astroquery-import #49

Merged
merged 10 commits into from
Apr 2, 2024
Merged

bugfix/astroquery-import #49

merged 10 commits into from
Apr 2, 2024

Conversation

alphasentaurii
Copy link
Collaborator

@alphasentaurii alphasentaurii commented Apr 2, 2024 •
edited
Loading

Resolves JP-3591

  • move HstSvmRadio import inside class method to avoid importing astroquery for other Scrub module sub-classes
  • temporarily pin tensorflow max version to 2.15 to ensure compatibility with models saved in tf 2.13 or older

Test config updates:

  • replace mock_s3 with mock_aws
  • matplotlib style settings (seaborn-bright replacement)
  • ruff.lint replaces depreacted top-level linter

@alphasentaurii alphasentaurii added documentation Improvements or additions to documentation testing analyzer labels Apr 2, 2024
@stscijgbot-jp stscijgbot-jp mentioned this pull request Apr 2, 2024
Closed
@alphasentaurii alphasentaurii merged commit adb6a92 into develop Apr 2, 2024
5 checks passed
@alphasentaurii alphasentaurii deleted the hotfix-astroquery branch April 2, 2024 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
analyzer documentation Improvements or additions to documentation extractor installation preprocessor testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@alphasentaurii