Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop unused dependencies #190

Merged
merged 3 commits into from
Dec 16, 2024
Merged

Conversation

braingram
Copy link
Contributor

@braingram braingram commented Dec 16, 2024

An attempted regtest run with python 3.13 showed a failure when the test machine failed to build getch:
https://github.com/spacetelescope/RegressionTests/actions/runs/12264011982/job/34217036983?pr=183#step:14:38
I don't see any uses of this package. (FWIW The python 3.13 tests aren't failing in the CI here so the above failure could be seen as a bug in the proposed regtest test machine changes).

This PR removes unused dependencies:

  • getch: looks like a dead package (no release since 2013): https://pypi.org/project/getch/
  • colorama: this isn't imported
  • flake8: this was replaced by ruff

Copy link

codecov bot commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.32%. Comparing base (244858c) to head (13de9ec).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #190      +/-   ##
==========================================
+ Coverage   90.02%   90.32%   +0.29%     
==========================================
  Files          17       17              
  Lines        2165     2170       +5     
==========================================
+ Hits         1949     1960      +11     
+ Misses        216      210       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@braingram braingram marked this pull request as ready for review December 16, 2024 15:50
@braingram braingram requested a review from a team as a code owner December 16, 2024 15:50
@schlafly
Copy link
Collaborator

Thanks!

@schlafly schlafly merged commit 5adef8e into spacetelescope:main Dec 16, 2024
20 checks passed
@schlafly
Copy link
Collaborator

(and FWIW, e.g. getch and colorama date back to the original skeleton commits before I started and we actually had written any non-boilerplate code, so ... no problem dropping them!)

@braingram braingram deleted the drop_getch branch December 16, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants