Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle cases where more than 2 billion photons enter a pixel. #188

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

schlafly
Copy link
Collaborator

@schlafly schlafly commented Dec 6, 2024

When more than 2 billion photons are modeled as entering a pixel, the current code trips and dies. This caps the number of photons entering a pixel to 2**31 - 1.

@schlafly schlafly requested a review from a team as a code owner December 6, 2024 14:19
Copy link

codecov bot commented Dec 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.32%. Comparing base (244858c) to head (146c6d3).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #188      +/-   ##
==========================================
+ Coverage   90.02%   90.32%   +0.29%     
==========================================
  Files          17       17              
  Lines        2165     2170       +5     
==========================================
+ Hits         1949     1960      +11     
+ Misses        216      210       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@schlafly schlafly merged commit 72f0084 into spacetelescope:main Dec 6, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant