-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove units from roman data model outputs #165
Conversation
a3186c5
to
023c4ac
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #165 +/- ##
==========================================
+ Coverage 89.24% 91.08% +1.83%
==========================================
Files 17 16 -1
Lines 2073 2119 +46
==========================================
+ Hits 1850 1930 +80
+ Misses 223 189 -34 ☔ View full report in Codecov by Sentry. |
@zacharyburnett , does this MacOS python 3.13 failure make sense to you? We once barred python >= 3.13, but somehow the MacOS job wants to use it and then fails. |
Yeah, looks like when unpinned, Tox grabs the latest Python without checking if the project can support it, and the install fails because |
This PR removes the units from output data models, to reflect changes in rad / roman_datamodels that remove units there.
It also includes two extraneous doc fixes (sorry!)