Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove units from roman data model outputs #165

Merged
merged 8 commits into from
Oct 21, 2024

Conversation

schlafly
Copy link
Collaborator

@schlafly schlafly commented Oct 8, 2024

This PR removes the units from output data models, to reflect changes in rad / roman_datamodels that remove units there.

It also includes two extraneous doc fixes (sorry!)

@schlafly schlafly requested a review from a team as a code owner October 8, 2024 20:30
@schlafly schlafly marked this pull request as draft October 8, 2024 20:30
Copy link

codecov bot commented Oct 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.08%. Comparing base (81028a8) to head (9eccf21).
Report is 11 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #165      +/-   ##
==========================================
+ Coverage   89.24%   91.08%   +1.83%     
==========================================
  Files          17       16       -1     
  Lines        2073     2119      +46     
==========================================
+ Hits         1850     1930      +80     
+ Misses        223      189      -34     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@schlafly
Copy link
Collaborator Author

@zacharyburnett , does this MacOS python 3.13 failure make sense to you? We once barred python >= 3.13, but somehow the MacOS job wants to use it and then fails.

@zacharyburnett
Copy link
Collaborator

zacharyburnett commented Oct 21, 2024

Yeah, looks like when unpinned, Tox grabs the latest Python without checking if the project can support it, and the install fails because romanisim explicitly doesn't want 3.13; we should test unpinning Python (see #167), and if that doesn't work change the toxenv in the CI to py312-xdist

@schlafly schlafly marked this pull request as ready for review October 21, 2024 18:37
@schlafly schlafly merged commit 4c19b59 into spacetelescope:main Oct 21, 2024
21 of 22 checks passed
@schlafly schlafly deleted the remove-units branch October 21, 2024 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants