-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SCSB-170] pin Python<3.13 #139
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #139 +/- ##
=======================================
Coverage 89.95% 89.95%
=======================================
Files 17 17
Lines 1792 1792
=======================================
Hits 1612 1612
Misses 180 180 ☔ View full report in Codecov by Sentry. |
I'm merging this since it resolves the build failures, but I'm confused about the content of the PR, which looks more like "build wheels for python != 3.13" and the title of the PR (pin python <3.13). |
Oh sorry! I was working with a very similar PR in another tab and must have gotten them confused. |
Sounds good, thanks. Do you understand the issue? Somehow I expect python 3.13 problems to manifest as syntax errors or unit test errors and not only in compiling the binaries, but maybe if cython isn't happy with 3.13 then it might only appear when building wheels. |
I don't understand the issue, but from further experimentation with I'll make another PR |
Resolves SCSB-170