Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add numpy lint #435

Merged
merged 1 commit into from
Dec 2, 2024
Merged

Conversation

WilliamJamieson
Copy link
Collaborator

Romancal uses this, specifically it catches issues with misuse of random number generation to create non-deterministic tests. I missed adding this in #433.

Tasks

  • Update or add relevant roman_datamodels tests.
  • Update relevant docstrings and / or docs/ page.
  • Does this PR change any API used downstream? (If not, label with no-changelog-entry-needed.)
News fragment change types:
  • changes/<PR#>.feature.rst: new feature
  • changes/<PR#>.bugfix.rst: fixes an issue
  • changes/<PR#>.doc.rst: documentation change
  • changes/<PR#>.removal.rst: deprecation or removal of public API
  • changes/<PR#>.misc.rst: infrastructure or miscellaneous change

Copy link

codecov bot commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.34%. Comparing base (087a60d) to head (043c40c).
Report is 83 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #435      +/-   ##
==========================================
- Coverage   97.56%   97.34%   -0.22%     
==========================================
  Files          30       37       +7     
  Lines        2788     3317     +529     
==========================================
+ Hits         2720     3229     +509     
- Misses         68       88      +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Romancal uses this, specifically it catches issues with misuse of random number generation to create non-deterministic tests
@WilliamJamieson WilliamJamieson merged commit e849ee4 into spacetelescope:main Dec 2, 2024
19 of 20 checks passed
@WilliamJamieson WilliamJamieson deleted the mnt/npy_check branch December 2, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants